Skip to content

[build]: add option to pull sonic-slave docker from registry#6300

Merged
lguohan merged 1 commit intosonic-net:masterfrom
lguohan:pull
Dec 26, 2020
Merged

[build]: add option to pull sonic-slave docker from registry#6300
lguohan merged 1 commit intosonic-net:masterfrom
lguohan:pull

Conversation

@lguohan
Copy link
Collaborator

@lguohan lguohan commented Dec 26, 2020

Signed-off-by: Guohan Lu lguohan@gmail.com

- Why I did it

  • add config option ENABLE_DOCKER_BASE_PULL to pull sonic-slave docker from registry
  • use REGISTRY_PORT, REGISTRY_SERVER to specify docker registry

- How I did it
add docker pull command before docker build

- How to verify it

checked following option and make sure the the behavior work as expected

  • ENABLE_DOCKER_BASE_PULL=y BLDENV=buster make -f Makefile.work sonic-slave-build
  • BLDENV=buster make -f Makefile.work sonic-slave-build
  • change rule/config and check

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

- add config option ENABLE_DOCKER_BASE_PULL to pull sonic-slave docker from registry
- use REGISTRY_PORT, REGISTRY_SERVER to specify docker registry

Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan lguohan requested review from qiluo-msft and xumia December 26, 2020 12:48
@lguohan lguohan merged commit a79fcb4 into sonic-net:master Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants